-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2.2 #257
v1.2.2 #257
Conversation
|
@falquaddoomi Can you take a look at this? The main changes of note are in |
Hey @vincerubinetti; agreed, the ORCID API docs leave a lot to be desired. Regarding issue #258, I think I was able to replicate the behavior Andrew reported with a publication in my ORCID account that has three sources: changing the preferred source changed the order of the elements in
I don't know if that's enough to resolve that issue, but I hope it helps. |
That's great, thanks for testing that out. None of my ORCID entries had multiple work summaries to test that with. With that extra data point, I feel confident enough that the api will do what it says (user-specified preferred sources become the highest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay; I made some comments on the Python code. All the other changes seemed straightforward to me.
Co-authored-by: Faisal Alquaddoomi <[email protected]>
@andrewsu Do you have time to give this code a quick look and these set of issues one last think? |
Closes #250
Closes #256
Closes #260
Closes #258
affiliation
to member portrait component